Implement MX conductor with multiple scattering#1991
Merged
Conversation
This moves the BSDF to libbsdl so we use the albedo tables infrastructure. Adds roughness regularization and energy compensation (multiple scattering, Turquin style). I removed the thinfilm options that were not implemented and don't exist in the MaterialX spec. Also I propose thinfilm to be implemented as a decoration via vertical layering so we don't repeat the parameters in every BSDF/closure. Signed-off-by: Alejandro Conty <aconty@imageworks.com>
lgritz
approved these changes
Jun 5, 2025
lgritz
left a comment
lgritz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Anybody else have comments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves the BSDF to libbsdl so we use the albedo tables infrastructure. Adds roughness regularization and energy compensation (multiple scattering, Turquin style).
I removed the thinfilm options that were not implemented and don't exist in the MaterialX spec. Also I propose thinfilm to be implemented as a decoration via vertical layering so we don't repeat the parameters in every BSDF/closure. But that would be a separate issue.
Here's a roughness wedge. It is not testrender but it is the same BSDF code verbatim.
Tests
Conductor tests pass and are now cleaner.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.